This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Move tests to correct sub-package #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/workspaces # Conflicts: # package-lock.json # package.json
Hinton
commented
Dec 15, 2021
|
Tests fails due on macos due to karma-webpack bug. Fixed in master but no new release yet. Pondering if we can tie it to a specific commit for now or hold off until it's merged. |
djsmith85
reviewed
Dec 17, 2021
…workspaces # Conflicts: # common/spec/importers/fsecureFskImporter.spec.ts # common/spec/services/cipher.service.spec.ts # package-lock.json # package.json
…workspaces # Conflicts: # spec/common/importers/firefoxCsvImporter.spec.ts # spec/common/importers/fsecureFskImporter.spec.ts # spec/common/importers/lastpassCsvImporter.spec.ts # spec/common/importers/nordpassCsvImporter.spec.ts # spec/common/importers/onepassword1PifImporter.spec.ts # spec/common/importers/onepasswordMacCsvImporter.spec.ts # spec/common/importers/onepasswordWinCsvImporter.spec.ts # spec/common/misc/sequentialize.spec.ts # spec/common/misc/throttle.spec.ts # spec/common/misc/utils.spec.ts # spec/common/services/cipher.service.spec.ts # spec/common/services/consoleLog.service.spec.ts # spec/common/services/export.service.spec.ts # spec/electron/services/electronLog.service.spec.ts # spec/electron/utils.spec.ts # spec/node/cli/consoleLog.service.spec.ts # spec/node/services/nodeCryptoFunction.service.spec.ts # spec/support/jasmine.json # spec/support/karma.conf.js # spec/utils.ts # spec/web/services/webCryptoFunction.service.spec.ts
Do you happen to have an issue/commit to link to? |
|
This was done in #744 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We previously split up the jslib repo into multiple modules but the tests remained in the root project. With npm v7 having support for workspaces, I sent some time cleaning it up and moving the tests to the correct packages.
This should also allow us to properly build each package independently and use the built files vs depending on the typescript source. Which I believe will help alleviate many of the issues we've encountered.
Before you submit
npm run lint) (required)