Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Examples docs to lib/zenohex/examples/README.md #17

Merged
merged 9 commits into from
Feb 19, 2024

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Feb 16, 2024

Github 上での表示は以下リンク先のようになります。

https://github.com/b5g-ex/zenohex/blob/pojiro/update-examples-docs/lib/zenohex/examples/README.md

@pojiro pojiro changed the title Move Examples.Publisher doc to lib/zenohex/examples/README.md Move Examples docs to lib/zenohex/examples/README.md Feb 16, 2024
@pojiro pojiro force-pushed the pojiro/update-examples-docs branch from e9c5112 to 8cb3be2 Compare February 16, 2024 06:42
@pojiro pojiro force-pushed the pojiro/update-examples-docs branch from 8cb3be2 to 16bcc41 Compare February 16, 2024 06:59
@pojiro pojiro marked this pull request as ready for review February 16, 2024 07:05
Comment on lines +57 to +59
"lib/zenohex.ex",
"lib/zenohex/config",
"lib/zenohex/*.ex",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/zenohex/examples ディレクトリを hex パッケージに含めないようにしました。

Copy link
Contributor

@takasehideki takasehideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@@ -63,18 +63,9 @@ iex(6)> Zenohex.Subscriber.recv_timeout(subscriber, 1000)

### Practical examples

We implemented following practical examples under the [lib/zenohex/examples](lib/zenohex/examples) with moduledoc.
We implemented practical examples under the [lib/zenohex/examples](https://github.com/b5g-ex/zenohex/tree/v0.2.0-rc.2/lib/zenohex/examples).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ただの自分用めも:これと下のリンクは #12 のマージ後に私が README を修正する際に main を指すように変更することにします.

@pojiro pojiro merged commit de4d092 into pojiro/0.2.0-dev Feb 19, 2024
4 checks passed
@pojiro pojiro deleted the pojiro/update-examples-docs branch February 19, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants