fix modifiers: root is "!", disable is "*" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--HG-- extra : source : 3f4e5502a0d7b061d630ccaeee704000cf8011fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am currently testing SolidPy and I find it very usable so far.
Your implementation seems to be much better than SolidPython, mainly because you are using methods, so the most important thing is in front (the geometric object) and modifications follow, which is nice.
I added three convenient unary operators:
~Obj -> Obj.debug = True
-Obj -> Obj.disable = True
+Obj -> Obj.background = True
These can be used as quick as the openscad modifiers.
While testing these I noticed that the modifiers root and disable were interchanged when generating openscad code, root should be ! and disable should be *