Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to .NET 8 #35

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Updated to .NET 8 #35

merged 6 commits into from
Sep 14, 2024

Conversation

daghsentinel
Copy link

  • Updated target frameworks to .NET 8
  • Updated global.json to current SDK
  • Updated nuget versions
  • Refactored code

@daghsentinel
Copy link
Author

I appreciate if you have the time to review this, @bjorkstromm !

Copy link
Owner

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments. I'll make the changes myself and then merge this PR. Thanks for updating to .NET 8

src/Depends/Depends.csproj Outdated Show resolved Hide resolved
src/Depends/Depends.csproj Outdated Show resolved Hide resolved
src/Depends/Depends.csproj Outdated Show resolved Hide resolved
src/Depends/Depends.csproj Outdated Show resolved Hide resolved
src/Depends/Depends.csproj Outdated Show resolved Hide resolved
src/Depends/Depends.csproj Outdated Show resolved Hide resolved
@bjorkstromm
Copy link
Owner

I'll have a closer look at the refactorings maybe tomorrow.

@daghsentinel
Copy link
Author

Hi, Thanks! I forgot to correct these. I had the impression that this project was dead, and started out on the journey towards a new fork - forgetting to revert these changes.

Thanks for looking into this!

@tom-haines
Copy link

Also looking forward to this one :)

@daghsentinel
Copy link
Author

Any news on this PR?

@westdavidr
Copy link

Can we get this one merged? This is a fantastic tool!

@daghsentinel
Copy link
Author

Looks like a dead project. Again.

@bjorkstromm bjorkstromm merged commit e12e4f6 into bjorkstromm:master Sep 14, 2024
1 check failed
@bjorkstromm
Copy link
Owner

Thank you @daghsentinel and sorry for the delay. Life got in the way 😞

@bjorkstromm bjorkstromm mentioned this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants