Skip to content

Commit

Permalink
build: disable html trailing commas to avoid cherry-pick conflicts (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
johnhwhite authored Jul 23, 2024
1 parent b384178 commit 03e6062
Show file tree
Hide file tree
Showing 12 changed files with 40 additions and 32 deletions.
10 changes: 9 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,13 @@
"importOrderSeparation": true,
"importOrderSortSpecifiers": true,
"importOrderParserPlugins": ["typescript", "jsx", "decorators-legacy"],
"plugins": ["@trivago/prettier-plugin-sort-imports"]
"plugins": ["@trivago/prettier-plugin-sort-imports"],
"overrides": [
{
"files": ["*.html"],
"options": {
"trailingComma": "none"
}
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { SkyInlineDeleteModule } from '@skyux/layout';
[ngStyle]="{
height: row.rowHeight + 'px',
position: 'fixed',
width: tableWidth + 'px'
width: tableWidth + 'px',
}"
#inlineDeleteRef
>
Expand Down
6 changes: 3 additions & 3 deletions libs/components/core/src/lib/modules/affix/affixer.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ import { SkyAffixer } from './affixer';
class="affixer-layer"
[ngClass]="{
'affix-layer-fixed': fixedLayer1,
'affix-layer-overflow': overflowLayer1
'affix-layer-overflow': overflowLayer1,
}"
>
<div
class="affixer-layer"
[ngClass]="{
'affix-layer-fixed': fixedLayer2,
'affix-layer-overflow': overflowLayer2
'affix-layer-overflow': overflowLayer2,
}"
>
<div
class="affixer-layer"
[ngClass]="{
'affix-layer-fixed': fixedLayer3,
'affix-layer-overflow': overflowLayer3
'affix-layer-overflow': overflowLayer3,
}"
>
<div class="affixer-container">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
class="sky-file-attachment-label-wrapper"
[attr.id]="labelElementId"
[ngClass]="{
'sky-control-label-required': !labelText && required && hasLabelComponent,
'sky-control-label-required': !labelText && required && hasLabelComponent
}"
>
<ng-container *ngIf="labelText; else labelContent">
<span
*ngIf="!labelHidden"
class="sky-control-label sky-margin-inline-xs"
[ngClass]="{
'sky-control-label-required': required,
'sky-control-label-required': required
}"
>{{ labelText }}</span
><sky-help-inline
Expand All @@ -32,7 +32,7 @@
class="sky-file-attachment-upload sky-file-attachment sky-file-attachment-target"
[ngClass]="{
'sky-file-attachment-accept': acceptedOver,
'sky-file-attachment-reject': rejectedOver,
'sky-file-attachment-reject': rejectedOver
}"
(dragenter)="fileDragEnter($event)"
(dragover)="fileDragOver($event)"
Expand Down Expand Up @@ -136,7 +136,7 @@
"
[disabled]="disabled"
[skyThemeClass]="{
'sky-btn-icon-borderless': 'modern',
'sky-btn-icon-borderless': 'modern'
}"
(click)="deleteFileAttachment()"
#deleteButton="skyId"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
*ngIf="labelText"
class="sky-control-label sky-font-body-default sky-margin-stacked-xs"
[ngClass]="{
'sky-screen-reader-only': labelHidden,
'sky-screen-reader-only': labelHidden
}"
>
<span
class="sky-margin-inline-xs"
[ngClass]="{
'sky-control-label-required': required,
'sky-control-label-required': required
}"
>{{ labelText }}</span
><span class="sky-screen-reader-only" *ngIf="required">{{
Expand All @@ -31,7 +31,7 @@
class="sky-file-drop-col"
[ngClass]="{
'sky-file-drop-accept': acceptedOver,
'sky-file-drop-reject': rejectedOver,
'sky-file-drop-reject': rejectedOver
}"
>
<button
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*skyThemeIf="'default'"
class="sky-input-box"
[ngClass]="{
'sky-input-box-disabled': isDisabled,
'sky-input-box-disabled': isDisabled
}"
>
<div class="sky-form-group">
Expand All @@ -18,7 +18,7 @@
class="sky-input-box-input-group-inner"
[ngClass]="{
'sky-field-status-active': formControlHasFocus,
'sky-field-status-invalid': hasErrorsComputed,
'sky-field-status-invalid': hasErrorsComputed
}"
(focusin)="formControlFocusIn()"
(focusout)="formControlFocusOut()"
Expand All @@ -39,7 +39,7 @@
*skyThemeIf="'modern'"
class="sky-input-box"
[ngClass]="{
'sky-input-box-disabled': isDisabled,
'sky-input-box-disabled': isDisabled
}"
>
<div class="sky-input-box-group">
Expand All @@ -48,7 +48,7 @@
class="sky-input-box-group-form-control"
[ngClass]="{
'sky-input-box-group-form-control-focus': formControlHasFocus,
'sky-input-box-group-form-control-invalid': hasErrorsComputed,
'sky-input-box-group-form-control-invalid': hasErrorsComputed
}"
(focusin)="formControlFocusIn()"
(focusout)="formControlFocusOut()"
Expand Down Expand Up @@ -90,7 +90,7 @@
[for]="controlId"
[id]="labelId"
[ngClass]="{
'sky-control-label-required': required,
'sky-control-label-required': required
}"
>{{ labelText }}</label
>
Expand Down Expand Up @@ -197,7 +197,7 @@
class="sky-font-deemphasized sky-input-box-hint-text"
[ngClass]="{
'sky-input-box-hint-text-hidden': hintTextHidden,
'sky-screen-reader-only': hintTextScreenReaderOnly,
'sky-screen-reader-only': hintTextScreenReaderOnly
}"
[id]="hintTextId"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
!labelledBy ? undefined : labelTextElement.id + ' ' + labelledBy
"
[ngClass]="{
'sky-help-inline-hidden': helpKey && !helpSvc && !popoverContent,
'sky-help-inline-hidden': helpKey && !helpSvc && !popoverContent
}"
[skyPopover]="popoverContent ? popoverRef : undefined"
(click)="onClick()"
Expand All @@ -32,11 +32,11 @@
size="xs"
[baseIcon]="{
icon: 'circle-solid',
iconType: 'skyux',
iconType: 'skyux'
}"
[topIcon]="{
icon: 'help-i',
iconType: 'skyux',
iconType: 'skyux'
}"
/>
</button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[attr.data-sky-illustration-name]="name()"
[height]="pixelSize()"
[ngClass]="{
'sky-illustration-img-loaded': !!url(),
'sky-illustration-img-loaded': !!url()
}"
[src]="url()"
[width]="pixelSize()"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[attr.role]="ariaRole"
[skyThemeClass]="{
'sky-shadow sky-border-dark': 'default',
'sky-elevation-1-bordered': 'modern',
'sky-elevation-1-bordered': 'modern'
}"
>
<div class="sky-box-header-content">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
[ngClass]="{
'sky-lookup-focused': isInputFocused,
'sky-lookup-disabled': disabled,
'sky-lookup-single': selectMode === 'single',
'sky-lookup-single': selectMode === 'single'
}"
#lookupWrapper
>
Expand Down Expand Up @@ -39,7 +39,7 @@
<div
class="sky-lookup-search"
[ngClass]="{
'sky-field-status-active': isInputFocused && !disabled,
'sky-field-status-active': isInputFocused && !disabled
}"
>
<sky-tokens
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
[ngClass]="{
'sky-btn-default':
(themeSvc?.settingsChange | async)?.currentSettings?.theme?.name ===
'modern',
'modern'
}"
(click)="toggleCountrySearch(false)"
>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<section
class="sky-tile"
[ngClass]="{
'sky-tile-collapsed': isCollapsed,
'sky-tile-collapsed': isCollapsed
}"
[skyThemeClass]="{
'sky-box sky-elevation-1-bordered sky-padding-even-xl': 'modern',
'sky-box sky-elevation-1-bordered sky-padding-even-xl': 'modern'
}"
>
<header class="sky-tile-header">
Expand Down Expand Up @@ -37,7 +37,7 @@
: ('skyux_tile_help_default' | skyLibResources)
"
[skyThemeClass]="{
'sky-btn-icon-borderless': 'modern',
'sky-btn-icon-borderless': 'modern'
}"
(click)="helpButtonClicked()"
>
Expand All @@ -54,7 +54,7 @@
[direction]="isCollapsed ? 'down' : 'up'"
[skyThemeClass]="{
'sky-tile-tools-control': 'default',
'sky-margin-inline-default': 'modern',
'sky-margin-inline-default': 'modern'
}"
(directionChange)="chevronDirectionChange($event)"
>
Expand All @@ -70,7 +70,7 @@
"
[skyThemeClass]="{
'sky-tile-tools-control': 'default',
'sky-btn-icon-borderless sky-margin-inline-default': 'modern',
'sky-btn-icon-borderless sky-margin-inline-default': 'modern'
}"
(click)="settingsButtonClicked()"
>
Expand All @@ -88,7 +88,7 @@
[attr.aria-describedby]="ariaDescribedBy"
[skyThemeClass]="{
'sky-tile-tools-control': 'default',
'sky-btn-icon-borderless': 'modern',
'sky-btn-icon-borderless': 'modern'
}"
(click)="$event.stopPropagation()"
(keydown)="moveTile($event)"
Expand Down

0 comments on commit 03e6062

Please sign in to comment.