fix(components/datetime): ignore extraneous properties when setting c…

…alculator value (#2459)
blackbaud · Jul 10, 2024 · ace058d · ace058d
1 parent edeb684
commit ace058d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.spec.ts b/...components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.spec.ts
@@ -714,6 +714,15 @@ describe('Date range picker', function () {
     );
   }));
 
+  it('should ignore extraneous properties when setting the value', () => {
+    component.dateRange?.setValue({
+      foo: 'bar',
+      calculatorId: SkyDateRangeCalculatorId.LastWeek,
+    });
+
+    expect(() => fixture.detectChanges()).not.toThrow();
+  });
+
   describe('accessibility', () => {
     function verifyFormFieldsRequired(expectation: boolean): void {
       const inputBoxes =

diff --git a/libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts b/libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts
@@ -604,7 +604,7 @@ export class SkyDateRangePickerComponent
       }
 
       if (options?.emitEvent) {
-        this.formGroup.setValue(valueOrDefault);
+        this.formGroup.patchValue(valueOrDefault);
       }
     }
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -604,7 +604,7 @@ export class SkyDateRangePickerComponent @@
           }
           if (options?.emitEvent) {
-            this.formGroup.setValue(valueOrDefault);
+            this.formGroup.patchValue(valueOrDefault);
           }
         }
       }
@@ Expand Down @@