-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components/forms): character counter reads to screen readers at unobtrusive intervals #1947
Merged
Blackbaud-TrevorBurch
merged 12 commits into
9.x.x
from
character-counter-screen-reader-enhancements
Feb 7, 2024
Merged
fix(components/forms): character counter reads to screen readers at unobtrusive intervals #1947
Blackbaud-TrevorBurch
merged 12 commits into
9.x.x
from
character-counter-screen-reader-enhancements
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nobtrusive intervals
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b2d97db. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
...omponents/forms/src/lib/modules/character-counter/character-counter-indicator.component.html
Show resolved
Hide resolved
libs/components/forms/src/lib/modules/character-counter/character-counter-screen-reader.pipe.ts
Outdated
Show resolved
Hide resolved
libs/components/forms/src/lib/modules/character-counter/character-counter-screen-reader.pipe.ts
Outdated
Show resolved
Hide resolved
libs/components/forms/src/lib/modules/character-counter/character-counter-screen-reader.pipe.ts
Outdated
Show resolved
Hide resolved
libs/components/forms/src/lib/modules/character-counter/character-counter.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/components/forms/src/lib/modules/input-box/input-box.component.spec.ts
Outdated
Show resolved
Hide resolved
Blackbaud-PaulCrowder
approved these changes
Feb 7, 2024
Merged
blackbaud-sky-build-user
pushed a commit
that referenced
this pull request
Feb 7, 2024
…nobtrusive intervals (#1947)
Cherry-pick successful! 🍒 🎉 See #2001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#2638606