Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-examples): satisfy ESLint rules for action button and AG Grid code examples #2423

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Jul 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6b14e6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Blackbaud-SteveBrush Blackbaud-SteveBrush added the risk level (author): 1 No additional bugs expected from this change label Jul 2, 2024
@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review July 2, 2024 15:41
@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

  • (no component storybooks affected in this pr)

Apps:

Copy link
Member

@johnhwhite johnhwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of the data manager examples aren't loading data.

@Blackbaud-SteveBrush Blackbaud-SteveBrush enabled auto-merge (squash) July 2, 2024 18:13
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 26c36f5 into 10.x.x Jul 2, 2024
27 checks passed
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the eslint-code-examples-ag-grid branch July 2, 2024 18:18
@blackbaud-sky-build-user
Copy link
Collaborator

Cherry-pick successful! 🍒 🎉 See #2425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk level (author): 1 No additional bugs expected from this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants