Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/lists): repeater focus styles show on focus-visible in modern theme #2554

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix(components/lists): repeater focus styles show on focus-visible in modern theme #2554

merged 1 commit into from
Jul 26, 2024

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch commented Jul 25, 2024 •
edited by azure-boards bot
Loading

@azure-boards Azure Boards
Copy link

azure-boards bot commented Jul 25, 2024

✅ Successfully linked to Azure Boards work item(s):

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 25, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c80ad43. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 18 targets

Sent with 💌 from NxCloud.

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch added risk level (author): 1 No additional bugs expected from this change risk level (author): 2 This change has a slight chance of introducing a bug and removed risk level (author): 1 No additional bugs expected from this change labels Jul 25, 2024
@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

Apps:

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Jul 26, 2024
@Blackbaud-MattGregg Blackbaud-MattGregg self-requested a review July 26, 2024 13:07
Blackbaud-MattGregg
Blackbaud-MattGregg approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@Blackbaud-MattGregg Blackbaud-MattGregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me reviewing in playground.

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 4c6e357 into 10.x.x Jul 26, 2024
50 of 52 checks passed
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the repeater-modern-use-focus-visible branch July 26, 2024 14:26
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jul 26, 2024
Merged
blackbaud-sky-build-user pushed a commit that referenced this pull request Jul 26, 2024
@Blackbaud-TrevorBurch
fix(components/lists): repeater focus styles show on focus-visible in…
47bc802 
… modern theme (#2554)
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jul 26, 2024
Merged
@blackbaud-sky-build-user
Copy link
Collaborator

Cherry-pick successful! 🍒 🎉 See #2560

Blackbaud-TrevorBurch pushed a commit that referenced this pull request Jul 26, 2024
@blackbaud-sky-build-user
fix(components/lists): repeater focus styles show on focus-visible in…
f2d1de2 
… modern theme (#2554) (#2560)
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jul 26, 2024
Merged
@johnhwhite johnhwhite mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-SteveBrush Blackbaud-SteveBrush Blackbaud-SteveBrush approved these changes

@Blackbaud-MattGregg Blackbaud-MattGregg Blackbaud-MattGregg approved these changes

Assignees

@Blackbaud-SteveBrush Blackbaud-SteveBrush

Labels
risk level (author): 2 This change has a slight chance of introducing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackbaud-TrevorBurch @blackbaud-sky-build-user @Blackbaud-SteveBrush @Blackbaud-MattGregg