Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/modals): SkyModalTestingController.closeTopModal passes reason and result to the modal instance #2565

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(components/modals): SkyModalTestingController.closeTopModal passes reason and result to the modal instance #2565

merged 1 commit into from
Jul 29, 2024

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Jul 29, 2024 •
edited
Loading

@Blackbaud-SteveBrush
fix(components/modals): SkyModalTestingController.closeTopModal pas…
17f3caa 
…ses `reason` and `result` to the modal instance
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 29, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 17f3caa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@Blackbaud-SteveBrush Blackbaud-SteveBrush added the risk level (author): 2 This change has a slight chance of introducing a bug label Jul 29, 2024
@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

  • (no component storybooks affected in this pr)

Apps:

@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review July 29, 2024 14:20
@johnhwhite johnhwhite added the risk level (reviewer): 2 This change has a slight chance of introducing a bug label Jul 29, 2024
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 0337f78 into 10.x.x Jul 29, 2024
34 of 37 checks passed
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-modal-controller branch July 29, 2024 17:31
blackbaud-sky-build-user pushed a commit that referenced this pull request Jul 29, 2024
@Blackbaud-SteveBrush
fix(components/modals): SkyModalTestingController.closeTopModal pas…
9b6818e 
…ses `reason` and `result` to the modal instance (#2565)
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jul 29, 2024
Merged
@blackbaud-sky-build-user
Copy link
Collaborator

Cherry-pick successful! 🍒 🎉 See #2567

@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jul 29, 2024
Merged
Blackbaud-SteveBrush pushed a commit that referenced this pull request Jul 29, 2024
@blackbaud-sky-build-user
fix(components/modals): SkyModalTestingController.closeTopModal pas…
38c2778 
…ses `reason` and `result` to the modal instance (#2565) (#2567)
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Jul 29, 2024
Merged
@johnhwhite johnhwhite mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnhwhite johnhwhite johnhwhite approved these changes

Assignees
No one assigned
Labels
risk level (author): 2 This change has a slight chance of introducing a bug risk level (reviewer): 2 This change has a slight chance of introducing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackbaud-SteveBrush @blackbaud-sky-build-user @johnhwhite