angular 17 update

.cspell.json

@@ -1,4 +1,4 @@
 {
   "import": "node_modules/@skyux/dev-infra-private/.cspell-shared.json",
-  "words": ["novalidate", "tabindex", "interactable", "fetchpriority"]
+  "words": ["novalidate", "tabindex", "interactable", "fetchpriority", "xlink"]
 }

.eslintrc-overrides.json

@@ -38,7 +38,26 @@
     {
       "files": ["*.html"],
       "rules": {
-        "@angular-eslint/template/button-has-type": ["error"]
+        "@angular-eslint/template/alt-text": ["warn"],
+        "@angular-eslint/template/attributes-order": ["warn"],
+        "@angular-eslint/template/button-has-type": ["error"],
+        "@angular-eslint/template/conditional-complexity": ["warn"],
+        "@angular-eslint/template/cyclomatic-complexity": ["warn"],
+        "@angular-eslint/template/elements-content": ["error"],
+        "@angular-eslint/template/interactive-supports-focus": ["warn"],
+        "@angular-eslint/template/label-has-associated-control": ["warn"],
+        "@angular-eslint/template/no-any": ["error"],
+        "@angular-eslint/template/no-call-expression": ["warn"],
+        "@angular-eslint/template/no-distracting-elements": ["warn"],
+        "@angular-eslint/template/no-inline-styles": ["warn"],
+        "@angular-eslint/template/no-interpolation-in-attributes": ["warn"],
+        "@angular-eslint/template/no-positive-tabindex": ["warn"],
+        "@angular-eslint/template/prefer-control-flow": ["warn"],
+        "@angular-eslint/template/prefer-ngsrc": ["warn"],
+        "@angular-eslint/template/prefer-self-closing-tags": ["warn"],
+        "@angular-eslint/template/role-has-required-aria": ["error"],
+        "@angular-eslint/template/use-track-by-function": ["warn"],
+        "@angular-eslint/template/valid-aria": ["error"]
       }
     }
   ]

.github/workflows/cherry-pick.yml

@@ -4,7 +4,7 @@ on:
     types:
       - closed
     branches:
-      - 7.x.x
+      - 10.x.x
 
 env:
   TARGET_BRANCH: main
@@ -38,6 +38,7 @@ jobs:
         run: npm ci
 
       - name: Cherry pick
+        id: cherry-pick
         run: |
           # Set the git user to the author of the merge commit.
           git config user.name "$(git log -1 --pretty=format:'%an' ${{ github.event.pull_request.merge_commit_sha }})"
@@ -72,6 +73,8 @@ jobs:
             echo "CHERRY_PICK_RESULT=failed" >> $GITHUB_ENV
             exit 0
           fi
+
+          echo "commit_message=$(git log -1 --pretty=%s)" >> $GITHUB_OUTPUT
         env:
           GH_TOKEN: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
 
@@ -81,6 +84,7 @@ jobs:
           github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
           script: |
             const pr = context.payload.pull_request;
+            const title = ${{ toJson(steps.cherry-pick.outputs.commit_message) }};
             let body = `:cherries: Cherry picked from #${pr.number} [${pr.title}](${pr.html_url})`
             const prAzureBoardLink = pr.body?.match(/(?<=\[)AB#\d+(?=])/g);
             if (prAzureBoardLink) {
@@ -91,7 +95,7 @@ jobs:
               repo: context.repo.repo,
               head: process.env.CHERRY_PICK_BRANCH,
               base: process.env.TARGET_BRANCH,
-              title: `${pr.title} (#${pr.number})`,
+              title,
               body
             }).then(result => {
               console.log(`Created PR #${result.data.number}: ${result.data.html_url}`);

.github/workflows/ci.yml

@@ -6,10 +6,14 @@ on:
   pull_request:
   push:
     branches:
-      - main
+      - 10.x.x
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 env:
-  NX_CLOUD_DISTRIBUTED_EXECUTION: true
+  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
 
 jobs:
   install-deps:
@@ -39,16 +43,14 @@ jobs:
       - name: npm install
         if: steps.cache.outputs.cache-hit != 'true'
         run: npm ci
-      - name: Start Nx Cloud CI run
-        run: npx nx-cloud start-ci-run
 
   agents:
     name: Bootup Nx Cloud agent
     runs-on: ubuntu-latest
     needs: install-deps
     strategy:
       matrix:
-        agent: [1, 2, 3, 4, 5, 6, 7, 8]
+        agent: [1, 2, 3]
     steps:
       - uses: actions/checkout@v4
       - name: Retrieve node_modules cache
@@ -59,33 +61,71 @@ jobs:
       - name: Start Nx Agent ${{ matrix.agent }}
         run: npx nx-cloud start-agent
 
-  lint:
-    name: Lint
-    needs: install-deps
+  build-coverage-lint:
+    name: Build, code coverage unit tests, and linting
+    if: ${{ !startsWith( github.head_ref || github.ref_name, 'release-please--' ) }}
     runs-on: ubuntu-latest
+    needs: install-deps
     steps:
       - uses: actions/checkout@v4
         with:
-          # We need to fetch all branches and commits so that Nx affected has a base to compare against.
           fetch-depth: 0
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
-      # Rebase must happen before installing dependencies.
-      - name: Rebase current branch
-        run: node ./scripts/rebase-pr.js
-      - name: Derive appropriate SHAs for base and head for `nx affected` commands
-        uses: nrwl/nx-set-shas@v4
+      - run: npx nx-cloud start-ci-run --agent-count=3 --distribute-on="manual"
       - name: Retrieve node_modules cache
-        uses: actions/cache@v4
+        uses: actions/cache/restore@v4
         with:
           path: node_modules
           key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
+      - uses: nrwl/nx-set-shas@v4
+      # Rebase must happen before installing dependencies.
+      - name: Rebase current branch
+        run: node ./scripts/rebase-pr.js
+      - name: Run build, lint, test, and posttest for npm packages
+        run: |
+          npx nx affected --target build lint test posttest --configuration ci --parallel 1 --exclude '*,!tag:npm'
+      - name: Run lint, test, and posttest for non-npm packages
+        run: |
+          npx nx affected --target lint test posttest --configuration ci --parallel 1 --exclude 'tag:npm'
+      - name: Stop
+        if: ${{ always() }}
+        run: npx nx-cloud stop-all-agents
+
+  build:
+    name: Build
+    needs: build-coverage-lint
+    runs-on: ubuntu-latest
+    if: ${{ always() && !startsWith( github.head_ref || github.ref_name, 'release-please--' ) }}
+    steps:
+      - name: Run build
+        run: |
+          [ '${{ needs.build-coverage-lint.result }}' == 'success' ] && echo Built. || false
+
+  coverage:
+    name: Code coverage
+    needs: build-coverage-lint
+    runs-on: ubuntu-latest
+    if: ${{ always() && !startsWith( github.head_ref || github.ref_name, 'release-please--' ) }}
+    steps:
+      - name: Run code coverage
+        run: |
+          [ '${{ needs.build-coverage-lint.result }}' == 'success' ] && echo Code covered. || false
+
+  lint:
+    name: Lint
+    needs: build-coverage-lint
+    runs-on: ubuntu-latest
+    if: ${{ always() && !startsWith( github.head_ref || github.ref_name, 'release-please--' ) }}
+    steps:
       - name: Run lint
-        run: npx nx affected:lint --quiet --silent --parallel=5
+        run: |
+          [ '${{ needs.build-coverage-lint.result }}' == 'success' ] && echo Linted. || false
 
   check-workspace:
     name: Check dependencies and resources
+    if: ${{ !cancelled() && !startsWith( github.head_ref || github.ref_name, 'release-please--' ) }}
     needs: install-deps
     runs-on: ubuntu-latest
     steps:
@@ -100,7 +140,7 @@ jobs:
       - name: Rebase current branch
         run: node ./scripts/rebase-pr.js
       - name: Retrieve node_modules cache
-        uses: actions/cache@v4
+        uses: actions/cache/restore@v4
         with:
           path: node_modules
           key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
@@ -129,58 +169,25 @@ jobs:
       - name: Derive appropriate SHAs for base and head for `nx affected` commands
         uses: nrwl/nx-set-shas@v4
       - name: Retrieve node_modules cache
-        uses: actions/cache@v4
+        uses: actions/cache/restore@v4
         with:
           path: node_modules
           key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
       - name: Check code formatting
         run: npx nx format:check
 
-  build:
-    name: Build
-    needs: install-deps
-    runs-on: ubuntu-latest
-    if: ${{ github.event_name == 'pull_request' }}
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          # We need to fetch all branches and commits so that Nx affected has a base to compare against.
-          fetch-depth: 0
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-      # Rebase must happen before installing dependencies.
-      - name: Rebase current branch
-        run: node ./scripts/rebase-pr.js
-      - name: Derive appropriate SHAs for base and head for `nx affected` commands
-        uses: nrwl/nx-set-shas@v4
-      - name: Retrieve node_modules cache
-        uses: actions/cache@v4
-        with:
-          path: node_modules
-          key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
-      - name: Build
-        run: |
-          npx nx affected --target=build --parallel=5 --exclude '*,!tag:npm'
-
   build-dist:
     name: Build packages distribution
     needs: install-deps
     runs-on: ubuntu-latest
     if: ${{ github.event_name != 'pull_request' }}
     steps:
       - uses: actions/checkout@v4
-        with:
-          # We need to fetch all branches and commits so that Nx affected has a base to compare against.
-          fetch-depth: 0
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
-      # Rebase must happen before installing dependencies.
-      - name: Rebase current branch
-        run: node ./scripts/rebase-pr.js
       - name: Retrieve node_modules cache
-        uses: actions/cache@v4
+        uses: actions/cache/restore@v4
         with:
           path: node_modules
           key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
@@ -199,45 +206,18 @@ jobs:
           SLACK_CHANNEL: C01GY7ZP4HM
           SLACK_FOOTER: 'Blackbaud Sky Build User'
 
-  coverage:
-    name: Code coverage
-    needs: install-deps
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          # We need to fetch all branches and commits so that Nx affected has a base to compare against.
-          fetch-depth: 0
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-      # Rebase must happen before installing dependencies.
-      - name: Rebase current branch
-        run: node ./scripts/rebase-pr.js
-      - name: Derive appropriate SHAs for base and head for `nx affected` commands
-        uses: nrwl/nx-set-shas@v4
-      - name: Retrieve node_modules cache
-        uses: actions/cache@v4
-        with:
-          path: node_modules
-          key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}
-      - name: Code coverage
-        run: |
-          npx nx affected --target=test,posttest --parallel=5 --configuration=ci
-
   stop-agents:
     name: Stop Nx Cloud agents
     runs-on: ubuntu-latest
     if: ${{ !cancelled() }}
-    needs:
-      [install-deps, check-workspace, format, lint, build, build-dist, coverage]
+    needs: build-coverage-lint
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
       - name: Retrieve node_modules cache
-        uses: actions/cache@v4
+        uses: actions/cache/restore@v4
         with:
           path: node_modules
           key: ${{ runner.os }}-node-${{ needs.install-deps.outputs.node-version }}-modules-${{ hashFiles('package-lock.json') }}