fix(components/router): skyHref should shut down when the application is destroyed #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhwhite
added
the
risk level (author): 1
|
View your CI Pipeline Execution ↗ for commit ca0e38d.
☁️ Nx Cloud last updated this comment at |
Blackbaud-TrevorBurch
approved these changes
Feb 10, 2025
|
Cherry-pick successful! 🍒 🎉 See #3136 |
Blackbaud-PaulCrowder
pushed a commit
that referenced
this pull request
Feb 10, 2025
🤖 I have created a release *beep* *boop* --- ## [11.40.0](11.39.0...11.40.0) (2025-02-10) ### Features * **components/pages:** add `sky-modal-link-list` component ([#3131](#3131)) ([d54bb9c](d54bb9c)) * **components/popovers:** add support for custom trigger buttons to dropdown harness ([#3129](#3129)) ([8ea599f](8ea599f)) ### Bug Fixes * **components/router:** skyHref should shut down when the application is destroyed ([#3134](#3134)) ([1dde88d](1dde88d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
johnhwhite
added a commit
that referenced
this pull request
Feb 10, 2025
… is destroyed (#3134) (#3136) 🍒 Cherry picked from #3134 [fix(components/router): skyHref should shut down when the application is destroyed](#3134) [AB#3248042](https://dev.azure.com/blackbaud/f565481a-7bc9-4083-95d5-4f953da6d499/_workitems/edit/3248042) Co-authored-by: John White <[email protected]>
johnhwhite
added a commit
that referenced
this pull request
Feb 11, 2025
…margin-property * origin/11.x.x: fix(components/datetime): address flaky display behavior of key date tooltips (#3128) chore: release 11.40.0 (#3133) feat(components/popovers): add support for custom trigger buttons to dropdown harness (#3129) fix(components/router): skyHref should shut down when the application is destroyed (#3134) feat(components/pages): add `sky-modal-link-list` component (#3131)
johnhwhite
added a commit
that referenced
this pull request
Feb 18, 2025
* origin/main: feat(components/toast): add toast and toaster harness (#3141) (#3147) ci: workflow to keep automated-translations in sync (#3145) (#3148) chore: changelog for 11.41.0 (#3139) 🍒 (#3144) feat(components/popovers): add support for custom trigger buttons to dropdown harness (#3129) (#3137) feat(components/core): add SkyViewkeeper support for SkyAppViewportService properties (#3120) (#3143) feat(components/popovers): add custom trigger option to dropdown (#3118) (#3126) fix(components/datetime): address flaky display behavior of key date tooltips (#3128) (#3140) fix(components/router): skyHref should shut down when the application is destroyed (#3134) (#3136) chore: changelog for 11.40.0 (#3133) 🍒 (#3138) chore: add tokenization github copilot prompts (#3135) feat(components/pages): add `sky-modal-link-list` component (#3131) (#3132) chore: changelog for 11.39.0 (#3114) 🍒 (#3127) feat(components/manifest): add code example file contents (internal use only) (#3122) feat(components/layout): add harness for description list (#3124) (#3125) feat(components/split-view): tokenize split view styles (#3119) feat(components/errors): tokenize error styles (#3123) feat(components/inline-form): tokenize inline form styles (#3116) feat(components/pages): tokenize action hub styles (#3109) feat(components/layout): tokenize inline delete styles (#3111) feat(components/flyout): tokenize flyout styles (#3098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3248042