-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components/tabs): puts focus on active tab in mobile view #3182
Merged
Blackbaud-SandhyaRajasabeson
merged 7 commits into
11.x.x
from
vertical-tabs-active-tab-bug
Feb 28, 2025
Merged
fix(components/tabs): puts focus on active tab in mobile view #3182
Blackbaud-SandhyaRajasabeson
merged 7 commits into
11.x.x
from
vertical-tabs-active-tab-bug
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit ea3b360.
☁️ Nx Cloud last updated this comment at |
Component Storybooks: Apps: |
libs/components/tabs/src/lib/modules/vertical-tabset/vertical-tabset.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/components/tabs/src/lib/modules/vertical-tabset/vertical-tabset.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/components/tabs/src/lib/modules/vertical-tabset/vertical-tabset.component.ts
Outdated
Show resolved
Hide resolved
Blackbaud-TrevorBurch
approved these changes
Feb 28, 2025
blackbaud-sky-build-user
pushed a commit
that referenced
this pull request
Feb 28, 2025
Co-authored-by: Sandhya Adhirvuh <[email protected]>
Cherry-pick successful! 🍒 🎉 See #3190 |
Merged
johnhwhite
pushed a commit
that referenced
this pull request
Feb 28, 2025
🤖 I have created a release *beep* *boop* --- ## [11.43.1](11.43.0...11.43.1) (2025-02-28) ### Bug Fixes * **components/tabs:** puts focus on active tab in mobile view ([#3182](#3182)) ([154f5b2](154f5b2)) * mark all harness `hostSelector` properties as "internal" ([#3180](#3180)) ([e9666c7](e9666c7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Blackbaud-SandhyaRajasabeson
added a commit
that referenced
this pull request
Feb 28, 2025
…#3190) 🍒 Cherry picked from #3182 [fix(components/tabs): puts focus on active tab in mobile view](#3182) Co-authored-by: Sandhya Adhirvuh <[email protected]> Co-authored-by: Sandhya Adhirvuh <[email protected]>
johnhwhite
added a commit
that referenced
this pull request
Feb 28, 2025
* origin/main: fix(components/tabs): puts focus on active tab in mobile view (#3182) (#3190) chore: changelog for 11.43.1 (#3184) 🍒 (#3191) chore: update library resources (#3186) (#3187) ci: pin version for nrwl/nx-set-shas (#3188) (#3189) chore: release 12.0.0-alpha.6 (#3177) fix: mark all harness `hostSelector` properties as "internal" (#3180) (#3183)
johnhwhite
added a commit
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.