OTWO-7202 Enlistment page must render without code location (#1772)

blackducksoftware · Mar 7, 2024 · e99ab09 · e99ab09
1 parent 008b368
commit e99ab09
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/app/null_models/nil_code_location.rb b/app/null_models/nil_code_location.rb
@@ -2,12 +2,16 @@
 
 class NilCodeLocation < NullObject
   blank_methods :url, :nice_url
-  nil_methods :branch, :username, :password
+  nil_methods :branch, :username, :password, :cl_update_event_time, :best_code_set
 
   def scm_type
     :git
   end
 
+  def scm_name_in_english
+    :Git
+  end
+
   def do_not_fetch
     true
   end

diff --git a/app/null_models/null_object.rb b/app/null_models/null_object.rb
@@ -1,6 +1,10 @@
 # frozen_string_literal: true
 
 class NullObject
+  def id
+    rand(20_000)
+  end
+
   def nil?
     true
   end

diff --git a/test/controllers/enlistments_controller_test.rb b/test/controllers/enlistments_controller_test.rb
@@ -46,6 +46,14 @@ class EnlistmentsControllerTest < ActionController::TestCase
       _(response.body).must_match I18n.t('enlistments.index.failure.dnf_present')
     end
 
+    it 'must render page when code_location is null' do
+      Enlistment.any_instance.stubs(:code_location).returns(NilCodeLocation.new)
+
+      mock_and_get :index, params: { project_id: @project_id }
+
+      assert_response :ok
+    end
+
     it 'must render projects/deleted when project is deleted' do
       login_as @account
       ApplicationController.any_instance.stubs(:current_user_can_manage?).returns(true)