Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for remove_dupes with SQL_ASCII test case #54

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

drubio1989
Copy link

No description provided.

@@ -110,7 +110,7 @@ def test_remove_dupes_with_sql_acii_encoding
#Note: If there are two files that are identical except for the encoding, ohloh_scm should only keep one.
svn = SvnAdapter.new
diff_1 = OhlohScm::Diff.new(:action => "M", :path => "/FritzBoxDial/FritzBoxDial/formWählbox.vb")
diff_2 = OhlohScm::Diff.new(:action => "A", :path => "/FritzBoxDial/FritzBoxDial/formW\xC3\xA4hlbox.vb".force_encoding('ASCII'))
diff_2 = OhlohScm::Diff.new(:action => "A", :path => "/FritzBoxDial/FritzBoxDial/formWählbox.vb")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't verify the scenario, does it? There are two different actions, "Modify" and "Add", but the same file, "/FritzBoxDial/FritzBoxDial/formWählbox.vb" without any difference in representation -- that is, both are UTF8, whereas the removed line used Unicode encoding, which is what we saw in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants