feat: add new RPC method for block #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new RPC method `FoundNewBlockNonStream` to the BlockService - Update input and output types for existing RPC methods to accommodate new functionality - Modify generated gRPC client and server interfaces to include the new method - Adjust mock implementations to support the new RPC method Signed-off-by: Sean Zheng <[email protected]>
- Add a new method `ProcessBlockTransactionsNonStream` to the `TransactionService` for handling non-streaming block transactions. - Update the gRPC client and server interfaces to support the new non-streaming method. - Adjust the implementation for `ListTransactions` to reference the correct stream index. - Modify the mock for `ProcessBlockTransactionsNonStream` to facilitate testing. - Make corresponding changes in the protocol buffer definitions to reflect the new method. Signed-off-by: Sean Zheng <[email protected]>
- Add a new method `FoundNewBlockNonStream` to handle found blocks - Include a TODO note for implementation in the new method - Add a new method `ProcessBlockTransactionsNonStream` to process transactions for blocks - Include a TODO note for implementation in the new method Signed-off-by: Sean Zheng <[email protected]>
|
Risk Level 2 - /home/runner/work/ryze/ryze/app/domain/block/block_service.go The new method Risk Level 2 - /home/runner/work/ryze/ryze/app/domain/transaction/transaction_service.go The new method 🔍 Powered by Code Review GPT |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.