Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert is_login_page() to excavate rule #1844

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Oct 14, 2024

This PR converts our is_login_page() function, which was being used by httpx to detect login pages, to an excavate rule. In order to accomplish this, excavate was converted to an intercept module.

Making excavate an intercept module is the first step towards keeping a collection of simpler excavate rules as YAML files. By making it an intercept module, it now has the ability to tag events on-the-fly, before they're distributed to other modules.

@TheTechromancer TheTechromancer mentioned this pull request Oct 14, 2024
1 task
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93%. Comparing base (b5587df) to head (e81a549).
Report is 33 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #1844    +/-   ##
======================================
- Coverage     93%     93%    -0%     
======================================
  Files        350     354     +4     
  Lines      27274   27398   +124     
======================================
+ Hits       25166   25263    +97     
- Misses      2108    2135    +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 8c65e98 into dev Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants