Convert is_login_page() to excavate rule #1844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts our
is_login_page()
function, which was being used byhttpx
to detect login pages, to an excavate rule. In order to accomplish this, excavate was converted to an intercept module.Making excavate an intercept module is the first step towards keeping a collection of simpler excavate rules as YAML files. By making it an intercept module, it now has the ability to tag events on-the-fly, before they're distributed to other modules.