Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: warning pedantic void return #1598

Merged
merged 6 commits into from
Aug 12, 2023
Merged

Fix: warning pedantic void return #1598

merged 6 commits into from
Aug 12, 2023
+39 −24

Conversation

perigoso
Copy link
Contributor

Detailed description

Fix (some) warnings for -Wpedantic

See #1590 for context

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@perigoso
adiv5: fix void return pedantic warning
1b67000 
ISO C forbids 'return' with expression in function returning void
@perigoso
renesas: fix void return pedantic warning
e950c7d 
ISO C forbids 'return' with expression in function returning void
@perigoso
hosted/remote: fix void return pedantic warning
9fa397d 
ISO C forbids 'return' with expression in function returning void
@perigoso
hosted/cmsis_dap: fix void return pedantic warning
5cc3981 
ISO C forbids 'return' with expression in function returning void
@perigoso
hosted/ftdi_jtag: fix void return pedantic warning
b36a11c 
ISO C forbids 'return' with expression in function returning void
@perigoso
hosted: fix void return pedantic warning
41e7a93 
ISO C forbids 'return' with expression in function returning void
@perigoso perigoso changed the title Fix/warning pedantic void return Fix: warning pedantic void return Aug 10, 2023
@perigoso perigoso mentioned this pull request Aug 10, 2023
Open
43 tasks
dragonmux
dragonmux approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@dragonmux dragonmux added this to the v1.10 milestone Aug 12, 2023
@dragonmux dragonmux added the Enhancement General project improvement label Aug 12, 2023
@dragonmux dragonmux merged commit 14f2882 into blackmagic-debug:main Aug 12, 2023
6 checks passed
@perigoso perigoso deleted the fix/warning-pedantic-void-return branch August 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Enhancement General project improvement
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@perigoso @dragonmux