Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lpc43xx: fix part number typo for 433x and 435x #1938

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

via
Copy link
Contributor

@via via commented Sep 23, 2024

Detailed description

I have a lpc4337 dev board, and when trying to use bmda, a swd_scan reports:

*** 1   Unknown ARM Cortex-M Designer 0x43b Part ID 0x4c4 M4

and the console output of bmda is:

LPC43xx part ID: 0xa001ca30:00

Looking in lpc43xx.c, I do not see 0xa0010a30 associated with this part, but the reference manual has:
2024-09-23-175707_1149x966_scrot

This change now allows me to attach to the target:

No. Att Driver
 1      LPC433x M4

Your checklist for this pull request

Closing issues

@via
Copy link
Contributor Author

via commented Sep 23, 2024

Looking at this list, I think lpc435x might also be a typo, but I don't have that chip. Should I change it too?

@dragonmux
Copy link
Member

Ooo, that's fun - and yes, that does look like a pure typo. Please include the LPC435x too and then we'll get this reviewed and merged.

@via via changed the title lpc43xx: fix part number typo for 433x lpc43xx: fix part number typo for 433x and 435x Sep 23, 2024
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Sep 24, 2024
@dragonmux dragonmux added the Bug Confirmed bug label Sep 24, 2024
@dragonmux dragonmux merged commit a85b601 into blackmagic-debug:main Sep 24, 2024
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants