feat: Add battery reading wrapper #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces hasBatterySensor, readBatteryLevel, and sendSensorReadCmd to handle battery level reading from devices. These functions allow checking for a battery sensor, reading the battery level, and sending a sensor read command to the device.
|
|
| throw new ButtplugDeviceException("Device doesn't support SensorReadCmd!"); | ||
| } | ||
|
|
||
| final SensorReadCmd cmd = new SensorReadCmd(index, index); |
There was a problem hiding this comment.
I think the first argument here should be deviceIndex
blackspherefollower
requested changes
Nov 17, 2024
blackspherefollower
requested changes
Nov 18, 2024
...ug4j/src/main/java/io/github/blackspherefollower/buttplug4j/client/ButtplugClientDevice.java
Outdated
Show resolved
Hide resolved
|
In the last commit I changed to client.getNextMsgId() and I also added a timeout in the readBatteryLevel because in the case the device crashed or anything else it would hangs up indefinitely |
blackspherefollower
merged commit 5d7738d
into
blackspherefollower:master
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces hasBatterySensor, readBatteryLevel, and sendSensorReadCmd to handle battery level reading from devices. These functions allow checking for a battery sensor, reading the battery level, and sending a sensor read command to the device.