Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle loitering objects that are stationary #14221

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Handle loitering objects that are stationary #14221

merged 1 commit into from
Oct 8, 2024

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Oct 8, 2024

Proposed change

The review maintainer only looked at active objects. This means if an object became stationary before the loitering time was met then the review item would not be created. This PR makes the following changes:

  • Create a pending_loitering attribute for objects to signify if they are in a zone with loitering time set
  • Review items with loitering objects will stay "ongoing" as long as the object is loitering in the zone, because the user has configured that they care about an object loitering in that area

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 4eb17d4
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67053e6a2b287600088c8152

@hawkeye217 hawkeye217 merged commit 0b71cfa into dev Oct 8, 2024
13 checks passed
@hawkeye217 hawkeye217 deleted the loitering branch October 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants