Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure embeddings #14266

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Restructure embeddings #14266

merged 5 commits into from
Oct 10, 2024

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Oct 10, 2024

Proposed change

This PR removes the embeddings encapsulation from embeddings context and replaces it with a ZMQ proxy. This ensures that only one process interacts with the model so the model is not loaded multiple times.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 5521e56
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6707f33270d2cd0008882958

@NickM-27 NickM-27 merged commit 8ade85e into dev Oct 10, 2024
13 checks passed
@NickM-27 NickM-27 deleted the restructure-embeddings branch October 10, 2024 15:42
@kdill00
Copy link

kdill00 commented Oct 10, 2024

I am not sure where to relay this but using Safari on an iphone since the change from chromadb, explore page works fine one first load but when the page is refreshed it seems to stall out. I have to navigate to another page other than explore and then return back to it. If there is a better place to report let me know. Also GPU embeddings great. This model really makes it usable. With 60 or so odd tracked objects its very little cpu and gpu.

@NickM-27
Copy link
Sponsor Collaborator Author

there are a number of problems currently, not sure if embeddings are actually working currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants