Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty description for tracked objects #14271

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented Oct 10, 2024

Proposed change

The Fast API changes set a min length for a string to be 1. This PR allows a blank description to be set for a tracked object. Also fixes a bug where embeddings would not be removed when when deleting events via the API.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit d17ca52
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67085d4217dcf20008a341a2
😎 Deploy Preview https://deploy-preview-14271--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hawkeye217 hawkeye217 merged commit 8d753f8 into dev Oct 10, 2024
13 checks passed
@hawkeye217 hawkeye217 deleted the allow-empty-description branch October 10, 2024 23:12
@hawkeye217 hawkeye217 mentioned this pull request Oct 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants