Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
For the Jina AI models, text-text cosine similarity is normally larger than text-image cosine similarity. This PR applies normalization for all vector based searches, uses cosine similarity on image-image searches, and only saves Z score normalization stats for multi-modal searches.
Type of change
Additional information
Users running the dev builds will have to set
reindex: True
in their config to regenerate their embeddings as distance function has now been changed to cosine.Checklist
ruff format frigate
)