Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbrake.xml #231

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 54 additions & 18 deletions release/handbrake.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@
<!--

BleachBit
Copyright (C) 2013 Andrew Ziem
http://www.bleachbit.org

Cleaner for HandBrake
Copyright © 2012-2013 Rogério Theodoro de Brito.
Copyright © 2016 Erratalog
Copyright (C) 2008-2019 Andrew Ziem
https://www.bleachbit.org

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
Expand All @@ -22,26 +18,66 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.

@app HandBrake
@url https://handbrake.fr/
@os Windows, Linux
@cleanerversion v0.5.0
@cleanerdate 2019-03-18
@cleanerby Rogério Theodoro de Brito (2012 - 2013) & Erratalog (2016) & Tobias B. Besemer (2019-03-18)
@tested ok v???, Windows ???
@testeddate ???
@testedby ???
@note This cleaner makes the WinApp2.ini entries to Handbrake necessary!

-->
<cleaner id="handbrake">
<label>HandBrake</label>
<description>Video transcoder</description>
<!-- Not yet figured out:
<running type="exe" os="linux">handbrake</running>
-->
<running type="exe" os="windows">Handbrake</running>
<var name="ProgramFiles">
<!--
Linux $$ProgramFiles$$ not yet figured out! I will do this later! Tobias.
<value os="linux">~/.config/ghb</value>
-->
<!--
Windows itself changes %ProgramFiles% for 32-bit processes running in a 64-bit operating system as documented here:
https://docs.microsoft.com/en-us/windows/desktop/winprog64/wow64-implementation-details
...so we use %SystemDrive%\Program Files\ & %SystemDrive%\Program Files (x86)\...
-->
<value os="windows">%SystemDrive%\Program Files\HandBrake</value>
<value os="windows">%SystemDrive%\Program Files (x86)\HandBrake</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this Wikipedia article on Program Files, the directory name can be localized, so these paths may break on some systems. It's best to use Program Files environment variables instead.

Can Handbreak be installed in both the x86 and "regular"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32bit builds are no longer provided.

But were in the past...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please change the ProgramFiles here to be like BiglyBT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done it already! Just didn't made a PR by now...

</var>
<option id="logs">
<label>Remove old logs</label>
<description>Remove logs of old transcodings</description>
<!-- Linux -->
<label>Logs</label>
<description>Delete the logs</description>
<!-- Linux: -->
<action command="delete" search="glob" path="~/.config/ghb/Activity.log.*"/>
<action command="delete" search="walk.all" path="~/.config/ghb/EncodeLogs/"/>
<!-- Win -->
<action command="delete" search="walk.files" path="$APPDATA\HandBrake\logs\"/>
<action command="delete" search="walk.files" path="~/.config/ghb/EncodeLogs/"/>
<!-- Windows: -->
<action command="delete" search="walk.files" path="%AppData%\HandBrake\logs\"/>
</option>
<option id="queues">
<label>Remove queues of jobs</label>
<description>Remove queues of jobs</description>
<warning>Queues may contain transcoding jobs that were not yet completed and you will have to reschedule them</warning>
<!-- Linux -->
<label>Queues</label>
<description>Delete the files</description>
<!-- Linux: -->
<action command="delete" search="glob" path="~/.config/ghb/queue.*"/>
<!-- Win -->
<action command="delete" search="glob" path="$APPDATA\HandBrake\hb_queue_recovery*.xml"/>
<!-- Windows: -->
<action command="delete" search="glob" path="%AppData%\HandBrake\hb_queue_recovery*.xml"/>
</option>
<option id="temp">
<label>Temporary files</label>
<description>Delete the temporary files</description>
<!-- Delete *.tmp recursive: -->
<action command="delete" search="walk.files" path="~/.config/ghb/" regex="\.[Tt][Mm][Pp]$"/>
<action command="delete" search="walk.files" path="%AppData%\HandBrake\" regex="\.[Tt][Mm][Pp]$"/>
</option>
<option id="crash_reports">
<label>Crash reports</label>
<description>Delete the files</description>
<action command="delete" search="glob" path="$$ProgramFiles$$\*.stackdump"/>
<action command="delete" search="glob" path="%LocalAppData%\VirtualStore\Program Files*\HandBrake\*.stackdump"/>
</option>
</cleaner>