Add login with domain name instead of dn #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the behaviour of send_ldap_request to allow login with domain and username. If provider_info[:domain] is set and auth_method is user, this behaviour will trigger.
benklett
added a commit
to benklett/greenlight
that referenced
this pull request
Jul 23, 2020
With the new environment variable LDAP_DOMAIN. It is only used, if the auth_method user is selected. Then the domain session controller sets the domain field of the ldap_config which is then used in blindsidenetworks/bn-ldap-authentication#8 to build the bindRequest username like so: DOMAIN\USERNAME.
benklett
added a commit
to benklett/greenlight
that referenced
this pull request
Jul 23, 2020
With the new environment variable LDAP_DOMAIN. It is only used, if the auth_method user is selected. Then the domain session controller sets the domain field of the ldap_config which is then used in blindsidenetworks/bn-ldap-authentication#8 to build the bindRequest username like so: DOMAIN\USERNAME.
benklett
added a commit
to benklett/greenlight
that referenced
this pull request
Jul 23, 2020
With the new environment variable LDAP_DOMAIN. It is only used, if the auth_method user is selected. Then the domain session controller sets the domain field of the ldap_config which is then used in blindsidenetworks/bn-ldap-authentication#8 to build the bindRequest username like so: DOMAIN\USERNAME.
paulmenzel
reviewed
Oct 24, 2020
| else | ||
| username = provider_info[:uid] + '=' + user_params[:username] + ',' + provider_info[:base] | ||
| end | ||
| auth = { |
There was a problem hiding this comment.
In GitHub the line is too much indented. It should use the same level as end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the behaviour of send_ldap_request to allow login with domain
and username. If provider_info[:domain] is set and auth_method is user,
this behaviour will trigger.