Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for default presentations #965

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

paul1278
Copy link
Contributor

Description

This pull request adds the option to supply default presentations on the create-call. This is a good addition to the default params / override options.

When submitting a POST-request as create-call, the supplied body will be used. If there is no body supplied or it is initially a GET-request, the default presentations will be added.

Testing Steps

Set the following inside your environment:

DEFAULT_PRESENTATIONS: "https://test.bigbluebutton.org/default.pdf->default_1.pdf,https://test.bigbluebutton.org/default.pdf->default_2.pdf"

This will download the default BBB-presentation two times, with two different names to showcase the options.
-> is the separator of URL and name because this is unlikely to appear inside an URL. Also with that, it is possible to add base64-presentations in the future.

@paul1278
Copy link
Contributor Author

If you want anything changed please let me know

@pielonet
Copy link
Contributor

Hi,

Thanks for this PR that we have been waiting a long time for.
Please release a beta version we can test soon.

@krim404
Copy link

krim404 commented Oct 28, 2023

i would like to push this pull request, as this feature would help us a lot and we would love to see it merged in the official branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants