Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blitz Install #3909

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Fix Blitz Install #3909

merged 8 commits into from
Oct 25, 2022

Conversation

itsdillon
Copy link
Member

@itsdillon itsdillon commented Oct 17, 2022

Closes #3900

Fixes the issues with blitz install cli command by setting the correct directory & package manager when cloning a recipe from the official list.

  1. Introduced the findNodeModulesRoot function as a starting point.
  2. Check the right directory in checkLockFileExists to set the right package manager
  3. Set the correct chdir when installing a recipe from github (process.chdir(join(process.cwd(), "..")))

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 6551c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
blitz Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/codemod Patch
@blitzjs/config Patch
@blitzjs/generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@itsdillon itsdillon marked this pull request as ready for review October 19, 2022 14:37
@itsdillon itsdillon requested a review from beerose as a code owner October 19, 2022 14:37
@Jonovono
Copy link

Jonovono commented Oct 20, 2022

Just came to report this, awesome thanks @dillonraphael, will test this when it gets released :)

beerose and others added 2 commits October 22, 2022 11:29
* Fix material-ui recipe

* fix baseui

* fix bumbag

* fix logrocket

* fix the rest of the recipes

* remove setting defaultBranch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blitz install stuck on "Generating file diff" in new project
4 participants