-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blitz install for recipes that use the path helper #3995
Conversation
🦋 Changeset detectedLatest commit: 481ee8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@dillonraphael Hey nice catch, I was facing the same error trying to install the tailwind recipe. |
Thanks so much for the review @maotora. Love seeing the community get involved. So for the legacy framework (which can be found here https://github.com/blitz-js/legacy-framework), allowed for the |
Thanks for your response, @dillonraphael! I just tested this and I found there is another edge case to cover for Tailwindcss to get our coding files which no longer reside at pages or app directories. I came up with something like this which fixed it; // tailwind.config.js
module.exports = {
content: ["src/**/*.{js,ts,jsx,tsx}"],
theme: {
extend: {},
},
plugins: [],
} Which worked! |
Good find @maotora. Would you like to open another PR for updating the tailwind recipe (since this is tailwind recipe specific)? |
@dillonraphael sure I can do that. Will make a PR and tag you then. |
@dillonraphael done I've made a PR: here |
Still experiencing this in 2.0.2. |
Still experiencing this in 2.0.3 as well. I haven't tested to make sure but I think this might be an issue for projects that are using the App Router instead of the older Pages system. |
yeah @Doc0x1, that seems likely, we would need to add additional handling to also check for the existence of the |
Closes: #3900
What are the changes and their implications?
Check if
src/pages
directory exists in the installer paths helper, else use the rootpages
directory.Bug Checklist
pnpm changeset
in the root directory)