Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimal app template #4405

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

rene-demonsters
Copy link
Contributor

Closes: #4236

What are the changes and their implications?

Fixes #4236 for the minimal setup. The setup for the minimal app still depended on next 13.4.5 where 13.5 is the minimum. Although changes were made in #4237, these didn't get applied to the template for the minimum template, which causes that to actually still be broken.

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)
  • Integration test added (see test docs if needed)

Feature Checklist

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: aabac64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/generator Patch
blitz Patch
@blitzjs/codemod Patch
next-blitz-auth Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks for the PR! just one thing before we can merge

packages/generator/templates/minimalapp/package.js.json Outdated Show resolved Hide resolved
@rene-demonsters
Copy link
Contributor Author

@siddhsuresh Cheers, updated to 15.0.1 as requested.

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siddhsuresh siddhsuresh merged commit 5b20ce6 into blitz-js:main Jan 22, 2025
18 of 29 checks passed
@blitzjs-bot
Copy link
Contributor

Added @rene-demonsters contributions for doc and code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blitz app setup not working with 2.0.0-beta.34
3 participants