Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update egui to 0.30.0 #227

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update egui to 0.30.0 #227

wants to merge 4 commits into from

Conversation

CUB3D
Copy link

@CUB3D CUB3D commented Jan 18, 2025

No description provided.

@blitzarx1
Copy link
Owner

blitzarx1 commented Jan 19, 2025

Hi! Build fails with the changes

@CUB3D
Copy link
Author

CUB3D commented Jan 19, 2025

Hi, this is because the examples also pin the version of egui and petgraph. Notably the following can't build on a newer petgraph version:

  • demo because fdg depends on petgraph=0.6.4
  • bevy_basic because bevy_reflect and bevy_ecs depend on petgraph=0.6.5

Personally I only need egui >= 0.30 so I'm ditching the update to petgraph due to time constraints, but I'll note that your library works fine on 0.7.1 - it's just these example dependencies that are borked.

Couple of extra points:

  • The examples in examples/ aren't actually registered as examples in Cargo.toml which is why this was missed
  • Having cargo.lock committed here might be a problem, as its ignored by library consumers. Hence this worked in my project while breaking the examples by pinning the versions. If it wasn't here then some of these would not have broken I think.

@CUB3D CUB3D changed the title Update egui to 0.30.0 and petgraph to 0.7.1 Update egui to 0.30.0 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants