Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trad 1171 review proto create v2 #217

Closed
wants to merge 6 commits into from
Closed

Trad 1171 review proto create v2 #217

wants to merge 6 commits into from

Conversation

808putnam
Copy link
Contributor

This second impementation:

  1. Moves cargo.toml, cargo.lock, build.rs up to root folder.
  2. Moves src/lib.rs up to rust folder
  3. Updates "path" and "include" setting in cargo.toml accordingly.
  4. Tested across local references and reference from a git repository

@808putnam 808putnam requested a review from Lanikean November 7, 2024 15:26
@808putnam 808putnam closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lanikean Lanikean Awaiting requested review from Lanikean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@808putnam @Lanikean @tinystarinagalaxy