Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for erc1155 tokens #351

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

elie222
Copy link

@elie222 elie222 commented May 22, 2022

Related issue: #315

c = ContractWrapper(function_sighashes)
return c.implements('balanceOf(address,uint256)') and \
c.implements('safeTransferFrom(address,address,uint256,uint256,bytes)') and \
c.implements('safeBatchTransferFrom(address,address,uint256[],uint256[],bytes')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be c.implements('safeBatchTransferFrom(address,address,uint256[],uint256[],bytes)')
(Add a ( after the bytes)

@brucexc
Copy link

brucexc commented Jul 25, 2022

Related issue: #315

I think the part which is relevant to 'token_transfer' also needs to support ERC 1155.

@yongchand
Copy link
Contributor

yongchand commented Jul 26, 2022

Are you still working on this issue? Also, just out of curiosity, is function like balanceOfBatch not required?

brucexc added a commit to brucexc/ethereum-etl that referenced this pull request Jul 26, 2022
add erc1155 support, include token_transfer and receipt

fix blockchain-etl#351
@elie222
Copy link
Author

elie222 commented Jul 27, 2022

Are you still working on this issue? Also, just out of curiosity, is function like balanceOfBatch not required?

I'm not.

@gekpp
Copy link

gekpp commented Jul 28, 2022

Hi! Thank you for your contribution. Is there a way this PR to be merged?

@elie222
Copy link
Author

elie222 commented Aug 2, 2022

Hi! Thank you for your contribution. Is there a way this PR to be merged?

It needs more work. Fixing conflicts and the fixes mentioned above.

@gekpp
Copy link

gekpp commented Aug 3, 2022

It needs more work. Fixing conflicts and the fixes mentioned above.

Thank you for reply. Are you going to finish it or I can take it over?

@elie222
Copy link
Author

elie222 commented Aug 3, 2022

It needs more work. Fixing conflicts and the fixes mentioned above.

Thank you for reply. Are you going to finish it or I can take it over?

Take over. I won't be finishing it.

@yongchand
Copy link
Contributor

@gekpp Are you working on this issue?

@gekpp
Copy link

gekpp commented Sep 26, 2022

Hi @yongchand . No, unfortunately, i haven't manage to start working on it.

@leopoldjoy
Copy link

@gekpp @yongchand @elie222 What is the current status of this PR? If nobody is working on it, would it be possible to provide a clear list of what changes remain to get it working?

@yongchand
Copy link
Contributor

@leopoldjoy Hey, I have done this on ethereum compatible chain - will try to make PR by end of this week

@leopoldjoy
Copy link

@yongchand Amazing, thank you! If you need any help to make this happen, please let me know!

@yongchand
Copy link
Contributor

@leopoldjoy FYI, just uploaded PR. Let me know if there are additional fixes that I should make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants