Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *args, **kwargs on create_item_exporter(s) for flexiblility #408

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rightx2
Copy link

@rightx2 rightx2 commented Nov 5, 2022

The reason to add these args is the way item exporter created is always fixed(hard coded). Due to this, if I want to change the topic name in creating Pubsub or Kafka exporter, I have nothing to do except forking the project and changing the topic name in code level. By adding these args, we can avoid this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant