chore: manual dependabot - minimist #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emilyjablonski
commented
Oct 8, 2024
emilyjablonski
commented
Oct 8, 2024
emilyjablonski
added
the
1 review needed
ColinBuyck
added
ready to merge
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
Oct 30, 2024
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commitizenhas a dependencycz-conventional-changelogwhich itself depends on a vulnerable version of minimist - and it isn't a ranged dependency, so it is explicitly pulling in the vulnerable version. I was able to upgradecommitizenand removecz-conventional-changelogbecause we aren't using it anymore.Dependabot alert
Issue in commitizen
Description
I ensured that even with removing the conventional changelog setup, commitizen still works for me locally.
How Can This Be Tested/Reviewed?
If you have commitizen set up locally, you can try committing with an unformatted commit and ensure it fails.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: