-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support types without args #108
fix: support types without args #108
Conversation
Signed-off-by: Lucas Rangel Cezimbra <[email protected]> Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
Signed-off-by: Lucas Rangel Cezimbra <[email protected]> Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
Signed-off-by: Lucas Rangel Cezimbra <[email protected]> Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
Signed-off-by: Lucas Rangel Cezimbra <[email protected]> Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
Signed-off-by: Lucas Rangel Cezimbra <[email protected]> Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
b77c646
to
352d8fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to fix the CI for 3.8.
Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
d851c16
to
9b2bf0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasrcezimbra can you run pre-commit to fix the linting issues? |
Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
Signed-off-by: Lucas Rangel Cezimbra <[email protected]>
9b2bf0d
to
6b084d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue number of the reported bug or feature request: no related issue.
Describe your changes
The validator was not supporting types without args. For example:
This PR fixes it for lists, dicts, and tuples.
Testing performed
Written tests.