physrep-match logic #4757
Open
physrep-match logic #4757
+564
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Oct 9, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
markhannum
force-pushed
the
physrep_match_lsn
branch
8 times, most recently
from
4c7c2ad
to
6c856c3
Compare
roborivers
suggested changes
Oct 16, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 12/586 tests failed ⚠.
The first 10 failing tests are:
sc_inserts [setup failure]
comdb2sys_queueodh_generated [setup failure]
writes_remsql_partial_index_off_generated [setup failure]
ssl_remsql [setup failure]
sc_transactional_rowlocks_generated
timepart_trunc_multiddl_generated
commit_lsn_map_delete_generated
snap_ha_retry_newsi_generated
tunables
phys_rep_tiered_testfallback_generated
markhannum
force-pushed
the
physrep_match_lsn
branch
2 times, most recently
from
f8c3543
to
7b0758a
Compare
markhannum
force-pushed
the
physrep_match_lsn
branch
2 times, most recently
from
bf8260a
to
0851b9b
Compare
markhannum
force-pushed
the
physrep_match_lsn
branch
2 times, most recently
from
272e42a
to
b589108
Compare
Signed-off-by: Mark Hannum <[email protected]>
markhannum
force-pushed
the
physrep_match_lsn
branch
from
b589108
to
a546027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail quickly if parent host doesn't have correct logfiles. Revise registration logic to only return machines which could successfully serve as source-databases.