[8.0] Tweaking the current_connections metric #4819
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Nov 6, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/559 tests failed ⚠.
The first 10 failing tests are:
timepart_retention1 [setup failure]
writes_remsql_partial_index_off_generated [setup failure]
writes_remsql_names_fdbpush_generated [setup failure]
verify_error [setup failure]
analyze_fastinit_race
comdb2sys_pagesize_generated
comdb2sys
truncatesc_offline_generated
This patch excludes connections owned by either sockpool or the in-process cache from the current_connections metric. This is one of the metrics that we use internally to monitor database capacity. Since it is very little overhead for libevent based network to maintain idle connections, it makes sense to exclude donated connections from the metric. Signed-off-by: Rivers Zhang <[email protected]>
riverszhang89
force-pushed
the
appsockcount8
branch
from
ff357ba
to
138f424
Compare
roborivers
suggested changes
Nov 18, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 2/558 tests failed ⚠.
The first 10 failing tests are:
sc_dbstore_func
truncatesc_offline_generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch excludes connections owned by either sockpool or the in-process cache from the current_connections metric. This is one of the metrics that we use internally to monitor database capacity. Since it is very little overhead for libevent based network to maintain idle connections, it makes sense to exclude pooled connections from the metric.