{177931817} sp: Use dbstmt only if sqlite3_stmt exits #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshatsikarwar
commented
Jan 21, 2025
•
akshatsikarwar
commented
- Revert to metatable technique for managing dbstmt lifetime
- Use dbstmt only if sqlite3_stmt is still present
- Set flag in Lua-Table to indicate it is a dbrow
akshatsikarwar
force-pushed
the
lua-sql-row-emit
branch
from
4c48cea to
df45274
Compare
roborivers
suggested changes
Jan 22, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 3/595 tests failed ⚠.
The first 10 failing tests are:
analyze_exit_immediately
sc_swapfields_logicalsc_generated
disttxn
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
akshatsikarwar
force-pushed
the
lua-sql-row-emit
branch
from
df45274 to
eb79b95
Compare
|
/silent |
. Revert to metatable technique for managing dbstmt lifetime . Use dbstmt only if sqlite3_stmt is still present . Set flag in Lua-Table to indicate it is a dbrow Signed-off-by: Akshat Sikarwar <[email protected]>
akshatsikarwar
force-pushed
the
lua-sql-row-emit
branch
from
eb79b95 to
b7c99d9
Compare
roborivers
suggested changes
Jan 23, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 1/595 tests failed ⚠.
The first 10 failing tests are:
sc_datacopy_logicalsc_generated
markhannum
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.