fix: more robust generic arrow handling #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #29 Signed-off-by: Ashley Claymore <[email protected]>
acutmore
commented
Jan 14, 2025
| if (node.typeParameters && node.typeParameters.length) { | ||
| moveOpenParen = isAsync(node.modifiers) && spansLines(node.typeParameters.pos, node.typeParameters.end); |
There was a problem hiding this comment.
For some reason when I fixed a similar bug before I only applied the fix for async arrows. The return case hadn't occurred to me at the time.
|
Possibly worth adding test for |
Signed-off-by: Ashley Claymore <[email protected]>
robpalme
approved these changes
Jan 15, 2025
mkubilayk
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
fixes #29
Given:
We need to ensure the arrow function is still returned after erasing the type argument. This is achieved by moving the opening parentheses up:
Testing performed
Additional test fixtures have been added.