Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ruff auto fix as it gets in the way of development #72

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

blooop
Copy link
Owner

@blooop blooop commented Dec 7, 2024

Summary by Sourcery

Build:

  • Update ruff-pre-commit hook to version v0.8.2 and remove the auto-fix argument from the linter configuration.

Copy link

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

This PR removes the Ruff auto-fix functionality from the pre-commit configuration while keeping the formatter. It also updates the Ruff version from v0.7.3 to v0.8.2 and removes an outdated TODO comment.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified pre-commit configuration to remove Ruff auto-fix functionality
  • Updated Ruff version from v0.7.3 to v0.8.2
  • Removed Ruff linter hook with auto-fix functionality
  • Kept Ruff formatter hook unchanged
  • Removed outdated TODO comment in codespell section
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@blooop blooop merged commit 4fa00ac into main Dec 7, 2024
2 checks passed
@blooop blooop deleted the feature/pre-commit branch December 7, 2024 16:35
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blooop - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider keeping the Ruff linter but adjusting its configuration instead of removing it entirely. If auto-fixing is problematic, you could remove the --fix argument while maintaining the valuable linting checks.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant