Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
… into master.lion
  • Loading branch information
bluebox authored and bluebox committed Jan 24, 2021
2 parents 16ce12f + 311f072 commit d1ef839
Show file tree
Hide file tree
Showing 1,514 changed files with 1,519 additions and 1,323 deletions.
14 changes: 7 additions & 7 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling Skia
# and whatever else without interference from each other.
'skia_revision': '9702fc6f385205e43b49cf7e09222720cc11aa8c',
'skia_revision': '8d29ab630996586f702768cfc978fabce688e578',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling V8
# and whatever else without interference from each other.
Expand Down Expand Up @@ -250,7 +250,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling freetype
# and whatever else without interference from each other.
'freetype_revision': '8dc311320c19b6b008fc6f55218b8f238ec982cb',
'freetype_revision': '209e9841f28ef3b38b9784a39e85edf69a9a853d',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling freetype
# and whatever else without interference from each other.
Expand Down Expand Up @@ -1273,7 +1273,7 @@ deps = {
},

'src/third_party/perfetto':
Var('android_git') + '/platform/external/perfetto.git' + '@' + '44860edcd2606f62b21b82c6bf9042309fe70443',
Var('android_git') + '/platform/external/perfetto.git' + '@' + '122834484af3d2f68b0ee0320d0e9e08e4d59bad',

'src/third_party/perl': {
'url': Var('chromium_git') + '/chromium/deps/perl.git' + '@' + '6f3e5028eb65d0b4c5fdd792106ac4c84eee1eb3',
Expand Down Expand Up @@ -1515,7 +1515,7 @@ deps = {
Var('chromium_git') + '/external/github.com/gpuweb/cts.git' + '@' + '66460536ee975a3e98931b7b40a661a63fd9cd57',

'src/third_party/webrtc':
Var('webrtc_git') + '/src.git' + '@' + 'ef53a7fc0bc307ada3ebaaef10d2507e571186a8',
Var('webrtc_git') + '/src.git' + '@' + '90776cb0ef72d437983c8d29e5a7f2ac264c107d',

'src/third_party/libgifcodec':
Var('skia_git') + '/libgifcodec' + '@'+ Var('libgifcodec_revision'),
Expand Down Expand Up @@ -1587,15 +1587,15 @@ deps = {
Var('chromium_git') + '/v8/v8.git' + '@' + Var('v8_revision'),

'src-internal': {
'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@4c406c738cada0fa0aae1cb7d84d6f7ce333d19e',
'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@3ac05951062516a69a7f82b926df82e4b1d05052',
'condition': 'checkout_src_internal',
},

'src/chromeos/components/help_app_ui/resources/prod': {
'packages': [
{
'package': 'chromeos_internal/apps/help_app/app',
'version': 'pNxnip2F8wICOrBjoNUbN_PM0CdfAwj4mNlQSwyP7dgC',
'version': 'ZzdNx1RhNNM7W1NdBgJ2TuE7u2K6DBW9qC6-RqGDE2QC',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand All @@ -1606,7 +1606,7 @@ deps = {
'packages': [
{
'package': 'chromeos_internal/apps/media_app/app',
'version': 'KoDoxKsUgYmDk8Xbp62-4Mftkzdv-ER37BKn6ELSk8MC',
'version': 'Pn61iPHsiXYTFn4jm8-HfP55P3eyyfCpXMvhkhHk8H4C',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand Down
2 changes: 1 addition & 1 deletion build/fuchsia/linux.sdk.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.20210123.0.1
0.20210123.2.1
2 changes: 1 addition & 1 deletion build/fuchsia/mac.sdk.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.20210123.0.1
0.20210123.2.1
3 changes: 1 addition & 2 deletions cc/layers/picture_layer_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,7 @@ TEST(PictureLayerTest, ClearVisibleRectWhenNoTiling) {
gfx::Size layer_size(50, 50);
FakeContentLayerClient client;
client.set_bounds(layer_size);
client.add_draw_image(CreateDiscardablePaintImage(layer_size), gfx::Point(),
PaintFlags());
client.add_draw_image(CreateDiscardablePaintImage(layer_size), gfx::Point());
scoped_refptr<PictureLayer> layer = PictureLayer::Create(&client);
layer->SetBounds(gfx::Size(10, 10));

Expand Down
121 changes: 44 additions & 77 deletions cc/paint/discardable_image_map_unittest.cc

Large diffs are not rendered by default.

44 changes: 21 additions & 23 deletions cc/paint/oop_pixeltest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -520,9 +520,9 @@ TEST_P(OopImagePixelTest, DrawImage) {

auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
SkSamplingOptions sampling(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling,
nullptr);
display_item_list->EndPaintOfUnpaired(rect);
display_item_list->Finalize();

Expand Down Expand Up @@ -559,9 +559,9 @@ TEST_P(OopImagePixelTest, DrawImageScaled) {
auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
display_item_list->push<ScaleOp>(0.5f, 0.5f);
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
SkSamplingOptions sampling(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling,
nullptr);
display_item_list->EndPaintOfUnpaired(rect);
display_item_list->Finalize();

Expand Down Expand Up @@ -633,9 +633,8 @@ TEST_P(OopImagePixelTest, DrawRecordShaderWithImageScaled) {
PaintImage::GetNextId());
auto paint_image = builder.TakePaintImage();
auto paint_record = sk_make_sp<PaintOpBuffer>();
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
paint_record->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
SkSamplingOptions sampling(FilterQuality());
paint_record->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling, nullptr);
auto paint_record_shader = PaintShader::MakePaintRecord(
paint_record, gfx::RectToSkRect(rect), SkTileMode::kRepeat,
SkTileMode::kRepeat, nullptr);
Expand Down Expand Up @@ -732,9 +731,9 @@ TEST_P(OopImagePixelTest, DrawImageWithTargetColorSpace) {

auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
SkSamplingOptions sampling(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling,
nullptr);
display_item_list->EndPaintOfUnpaired(rect);
display_item_list->Finalize();

Expand Down Expand Up @@ -778,9 +777,9 @@ TEST_P(OopImagePixelTest, DrawImageWithSourceColorSpace) {

auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
SkSamplingOptions sampling(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling,
nullptr);
display_item_list->EndPaintOfUnpaired(rect);
display_item_list->Finalize();

Expand Down Expand Up @@ -823,9 +822,9 @@ TEST_P(OopImagePixelTest, DrawImageWithSourceAndTargetColorSpace) {

auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
SkSamplingOptions sampling(FilterQuality());
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling,
nullptr);
display_item_list->EndPaintOfUnpaired(rect);
display_item_list->Finalize();

Expand Down Expand Up @@ -863,10 +862,10 @@ TEST_P(OopImagePixelTest, DrawImageWithSetMatrix) {

auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
PaintFlags flags;
flags.setFilterQuality(FilterQuality());
SkSamplingOptions sampling(FilterQuality());
display_item_list->push<SetMatrixOp>(SkM44::Scale(0.5f, 0.5f));
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, &flags);
display_item_list->push<DrawImageOp>(paint_image, 0.f, 0.f, sampling,
nullptr);
display_item_list->EndPaintOfUnpaired(rect);
display_item_list->Finalize();

Expand Down Expand Up @@ -938,8 +937,7 @@ TEST_F(OopPixelTest, DrawMailboxBackedImage) {

auto display_item_list = base::MakeRefCounted<DisplayItemList>();
display_item_list->StartPaint();
PaintFlags flags;
display_item_list->push<DrawImageOp>(src_paint_image, 0.f, 0.f, &flags);
display_item_list->push<DrawImageOp>(src_paint_image, 0.f, 0.f);
display_item_list->EndPaintOfUnpaired(gfx::Rect(options.resource_size));
display_item_list->Finalize();

Expand Down
10 changes: 9 additions & 1 deletion cc/paint/paint_canvas.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,24 @@ class CC_PAINT_EXPORT PaintCanvas {
virtual void drawImage(const PaintImage& image,
SkScalar left,
SkScalar top,
const SkSamplingOptions&,
const PaintFlags* flags) = 0;
void drawImage(const PaintImage& image, SkScalar left, SkScalar top) {
drawImage(image, left, top, nullptr);
drawImage(image, left, top, SkSamplingOptions(), nullptr);
}

virtual void drawImageRect(const PaintImage& image,
const SkRect& src,
const SkRect& dst,
const SkSamplingOptions&,
const PaintFlags* flags,
SkCanvas::SrcRectConstraint constraint) = 0;
void drawImageRect(const PaintImage& image,
const SkRect& src,
const SkRect& dst,
SkCanvas::SrcRectConstraint constraint) {
drawImageRect(image, src, dst, SkSamplingOptions(), nullptr, constraint);
}

// Draws the frame of the |skottie| animation specified by the normalized time
// t [0->first frame..1->last frame] at the destination bounds given by |dst|
Expand Down
2 changes: 1 addition & 1 deletion cc/paint/paint_filter_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ sk_sp<PaintFilter> CreateTestFilter(PaintFilter::Type filter_type,
image, SkRect::MakeWH(100.f, 100.f), SkRect::MakeWH(100.f, 100.f),
kNone_SkFilterQuality);
auto record = sk_make_sp<PaintOpBuffer>();
record->push<DrawImageOp>(image, 0.f, 0.f, nullptr);
record->push<DrawImageOp>(image, 0.f, 0.f);
auto record_filter =
sk_make_sp<RecordPaintFilter>(record, SkRect::MakeWH(100.f, 100.f));

Expand Down
Loading

0 comments on commit d1ef839

Please sign in to comment.