Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow the webrtc player to pause #2486

Closed
wants to merge 1 commit into from

Conversation

DanTheMan827
Copy link
Contributor

I don't know why, maybe it's my specific sources, but there are times where the player will pause without throwing an error, this ensures that the player will always be in the playing state.

The player controls show that the video is still playing, but the video object says that the video is paused, this is why I pause() and then play().

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2486 (feb7a2a) into main (9de6423) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
+ Coverage   61.41%   61.43%   +0.01%     
==========================================
  Files         133      133              
  Lines       14904    14904              
==========================================
+ Hits         9154     9156       +2     
+ Misses       5061     5059       -2     
  Partials      689      689              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9
Copy link
Member

aler9 commented Oct 17, 2023

Hello, this patch adds a background job that increases CPU consumption, thus, before merging, i'd like to understand why the stream gets paused. Can you post a server log that shows the moment in which the stream is paused? do you have a file or a sample stream that can be used to replicate the issue?

@aler9
Copy link
Member

aler9 commented Dec 17, 2023

this can't be merged without further details.

@aler9 aler9 closed this Dec 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants