Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp: fix compatibility with nginx-rtmp-module (#2383) #2520

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 17, 2023

Fixes #2383

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2520 (1e1456d) into main (648e90f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
+ Coverage   61.08%   61.12%   +0.03%     
==========================================
  Files         138      138              
  Lines       15224    15224              
==========================================
+ Hits         9300     9305       +5     
+ Misses       5222     5217       -5     
  Partials      702      702              
Files Coverage Δ
internal/rtmp/conn.go 63.06% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 91f83a8 into main Oct 17, 2023
@aler9 aler9 deleted the bug/nginx-rtmp branch October 17, 2023 19:14
@winkmichael
Copy link

Unable to push RTMP feeds from nginx-rtmp module.

nginx-rtmp -> push to mediamtx

2023/10/25 23:59:45 INF [RTMP] [conn 24.16.62.11:1024] closed: invalid body size
2023/10/25 23:59:45 DEB [path public/WF03-61FD-A9A4-6AB0-7F89_test] created
2023/10/25 23:59:45 DEB [path public/WF03-6202-A9A4-AFB0-E084_test] created
2023/10/25 23:59:45 DEB [path public/WF03-6251-A9A4-29D3-6C37_test] destroyed: not in use
2023/10/25 23:59:45 INF [RTMP] [conn 24.16.62.11:1376] closed: invalid body size
2023/10/25 23:59:45 DEB [path public/WF03-61FD-A9A4-6AB0-7F89_test] destroyed: not in use
2023/10/25 23:59:45 INF [RTMP] [conn 24.16.62.11:1310] closed: invalid body size
2023/10/25 23:59:45 DEB [path public/WF03-6202-A9A4-AFB0-E084_test] destroyed: not in use
2023/10/25 23:59:45 INF [RTMP] [conn 24.16.62.11:1337] closed: invalid body size

@aler9
Copy link
Member Author

aler9 commented Oct 26, 2023

@winkmichael this is not the way to report bugs. Open an issue and provide instructions on how to replicate.

@bluenviron bluenviron locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stopped: timed out when pulling from nginx-rtmp
2 participants