use new protobuf API protobuf_generate #182
Conversation
| endif () | ||
|
|
||
| include(FindProtobuf) | ||
| find_package(Protobuf CONFIG REQUIRED) |
There was a problem hiding this comment.
Does this find_package require a particular CMake version or Protobuf version?
There was a problem hiding this comment.
aah, yepp, that was the catch...
this requires a "new" version of protobuf, but i dont know what version exactly
this may be a a problem on "always outdated" distros like debian...
There was a problem hiding this comment.
Yeah for protobuf we're stuck on the 3.21.X series unless we want to add the abseil dependency
There was a problem hiding this comment.
unless we want to add the abseil dependency
why not?
for me this just works
$ nix why-depends nixpkgs#protobuf nixpkgs#abseil-cpp
/nix/store/kdff9wgmdncv2bhik6mppra5nni10aa8-protobuf-24.4
└───/nix/store/xpxz880b33kilbw5lccvrqjk40i05ykp-abseil-cpp-20230125.3
There was a problem hiding this comment.
Because in general i don't want to add new dependencies without a good reason, an specifically here I would also need to update https://github.com/blueprint-freespeech/ricochet-build
fix #178
see also
https://gitlab.kitware.com/cmake/cmake/-/issues/24321
https://github.com/protocolbuffers/protobuf/blob/main/docs/cmake_protobuf_generate.md