Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new embed type for code blocks that supports syntax highlighting #3500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skiniks
Copy link

@skiniks skiniks commented Feb 6, 2025

This PR proposes a new embed type to enable code sharing in posts. This is an initial proposal to start the discussion and lay the groundwork for syntax-highlighted code blocks.

Implementation Details:

  • New app.bsky.embed.code lexicon with code (max 8000 chars) and lang (max 20 chars) fields
  • Follows existing embed patterns and integrates with current view system

Follow-up Considerations:

  • UI/UX details (truncation, expanding, copy button)
  • Additional metadata like line numbers could be added in future iterations

Interested in feedback on:

  1. The lexicon structure and field limits
  2. Integration approach with existing embed system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant