Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backdated post indicator #6156

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Add backdated post indicator #6156

merged 7 commits into from
Nov 12, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 8, 2024

Backdated post indicator. Requires backend changes to actually work

Indicator Info
Screenshot 2024-11-11 at 20 58 24 Screenshot 2024-11-11 at 20 46 54
Indicator Info
Screenshot 2024-11-11 at 20 58 41 Screenshot 2024-11-11 at 20 58 47

Test plan

Replace post.indexedAt with the current date (or go back to before the final commit)

-const indexedAt = new Date(post.indexedAt)
+const indexedAt = new Date()

Confirm posts older than 24 hours show the indicator

Confirm that the wording is good

@arcalinea arcalinea temporarily deployed to samuel/backdate-indicator - social-app PR #6156 November 8, 2024 01:53 — with Render Destroyed
Copy link

github-actions bot commented Nov 8, 2024

Old size New size Diff
8.01 MB 8.02 MB 4.08 KB (0.05%)

@arcalinea arcalinea temporarily deployed to samuel/backdate-indicator - social-app PR #6156 November 8, 2024 02:05 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/backdate-indicator - social-app PR #6156 November 11, 2024 21:05 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/backdate-indicator - social-app PR #6156 November 11, 2024 21:05 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/backdate-indicator - social-app PR #6156 November 11, 2024 21:06 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/backdate-indicator - social-app PR #6156 November 11, 2024 21:08 — with Render Destroyed
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm but have not tested (dont really know how to test, can test if theres a way to!)

<Prompt.DescriptionText>
<Trans>
This post claims to have been created on{' '}
<RNText style={[a.font_bold]}>{niceDate(i18n, createdAt)}</RNText>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small q, why do we use RNText here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested styles

@surfdude29
Copy link
Contributor

code lgtm but have not tested (dont really know how to test, can test if theres a way to!)

Sorry for jumping in here, this looks like it might be a good way to test? :)

"Test plan

Replace post.indexedAt with the current date (or go back to before the final commit)"

@mozzius mozzius merged commit 6471e80 into main Nov 12, 2024
6 checks passed
@mozzius mozzius deleted the samuel/backdate-indicator branch November 12, 2024 21:02
@Lucifer-is-my-pet
Copy link

Hello.

Is there a discussion of this feature anywhere? I'm one of the many people trying to get settled in Bluesky using import for my tweets (it is hard moving to a new place with nothing). But with this I will make thousands of posts in one day and flood other people's feeds because the created_at of tweets is ignored. And I just want my stuff to be on my new account here.

The main idea with labelling imported posts is great and I get the problem with misleading dates. But why not switch date on the label and post date and indicate the "unreliable" date for all to see (as described here #6707)?

Or will it be better to just make a pull request with necessary changes and wait for a review? I am willing to try if it will get us closer to a satisfactory solution.

@jamesleesaunders
Copy link
Contributor

Hello.

Is there a discussion of this feature anywhere? I'm one of the many people trying to get settled in Bluesky using import for my tweets (it is hard moving to a new place with nothing).

Hi @Lucifer-is-my-pet you may be interested to know I have put a proposal pull request in for a half-way solution #7466 this keeps parts of the 'Archived Post' messaging whilst restoring a timeline for imported posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants