-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backdated post indicator #6156
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm but have not tested (dont really know how to test, can test if theres a way to!)
<Prompt.DescriptionText> | ||
<Trans> | ||
This post claims to have been created on{' '} | ||
<RNText style={[a.font_bold]}>{niceDate(i18n, createdAt)}</RNText>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small q, why do we use RNText
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested styles
Sorry for jumping in here, this looks like it might be a good way to test? :) "Test plan Replace post.indexedAt with the current date (or go back to before the final commit)" |
Hello. Is there a discussion of this feature anywhere? I'm one of the many people trying to get settled in Bluesky using import for my tweets (it is hard moving to a new place with nothing). But with this I will make thousands of posts in one day and flood other people's feeds because the The main idea with labelling imported posts is great and I get the problem with misleading dates. But why not switch date on the label and post date and indicate the "unreliable" date for all to see (as described here #6707)? Or will it be better to just make a pull request with necessary changes and wait for a review? I am willing to try if it will get us closer to a satisfactory solution. |
Hi @Lucifer-is-my-pet you may be interested to know I have put a proposal pull request in for a half-way solution #7466 this keeps parts of the 'Archived Post' messaging whilst restoring a timeline for imported posts. |
Backdated post indicator. Requires backend changes to actually work
Test plan
Replace
post.indexedAt
with the current date (or go back to before the final commit)Confirm posts older than 24 hours show the indicator
Confirm that the wording is good