-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New spanish translations #7319
base: main
Are you sure you want to change the base?
New spanish translations #7319
Conversation
- Add new translations to reach 100% coverage - Change example name from Alice to Alicia in all examples - Change "desmutear" and derivatives to "Dejar de silenciar" - Remove comments - Minor fixes
- "Posts" and "Publications" (lists page) and "Following" tab - Run lingui extract - Translate those strings to Spanish - Translate other remaining strings to Spanish To validate: src/screens/Profile/components/ProfileFeedHeader.tsx:353 menú de feeds (menu "of feeds") or menú del feed (menu "of the feed")? src/view/screens/ProfileList.tsx:683 (and others) Dejar de fijar?" TODO: Delete obsolete strings from locales
src/view/screens/ProfileList.tsx
Outdated
@@ -162,6 +159,7 @@ function ProfileListScreenLoaded({ | |||
const isHidden = list.labels?.findIndex(l => l.val === '!hide') !== -1 | |||
const isOwner = currentAccount?.did === list.creator.did | |||
const scrollElRef = useAnimatedRef() | |||
const SECTION_TITLES_CURATE = [_(msg`Posts`), _(msg`People`)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7175 is already working on this, I suggest keeping it separate from the Spanish translation update PR to avoid overlaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks! I didn't notice. Will roll back the changes then.
Let’s first resolve some merge conflicts. When updating This ensures we keep changes scoped to Spanish translations only. |
- Solved conflicts in Spanish locale - "Theirs" strategy for the rest of locales - Rollback ProfileList.tsx to avoid overlap with bluesky-social#7175
I think that should solve the merge conflicts. What I did:
Thank you for your help and guidance! Happy to make any other changes if needed. |
Thank you for your efforts, but could we revert the changes to I noticed your improvements to |
@GersonLazaro @ovniroto Would anyone be willing to review the improvements proposed in this PR? It would be great if someone could take a look! |
src/locale/locales/es/messages.po
Outdated
|
||
#: src/screens/Post/PostLikedBy.tsx:41 | ||
msgid "{0, plural, one {# like} other {# likes}}" | ||
msgstr "" | ||
msgstr "{0, plural, one {# \"me gusta\"} other {# \"me gusta\"}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation has a small problem. There are places where there should be quotation marks, such as in phrases that determine that someone has given a like, as here:
However, in places where only the word "me gusta" appears, it should not have quotation marks, as here:
It would be good to identify the lines that have these problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular translation is solved in the current PR.
social-app/src/locale/locales/es/messages.po
Lines 4331 to 4333 in a0252d3
#: src/screens/Profile/components/ProfileFeedHeader.tsx:514 | |
msgid "Like" | |
msgstr "Me gusta" |
The other lines with this problem are:
social-app/src/locale/locales/es/messages.po
Line 118 in a0252d3
msgstr "{0, plural, one {\"me gusta\"} other {\"me gusta\"}}" |
and maybe:
social-app/src/locale/locales/es/messages.po
Line 4337 in a0252d3
msgstr "Me gusta ({0, plural, one {# \"me gusta\"} other {# \"me gusta\"}})" |
social-app/src/locale/locales/es/messages.po
Line 8753 in a0252d3
msgstr "Ya no me gusta ({0, plural, one {# \"me gusta\"} other {# \"me gusta\"}})" |
What do you think?
Hi all! I believe I have integrated all of your coments. Do you have anything else to review or can we move forward? Thanks! |
As promised, some more updates for the Spanish localization:
Add new translations to reach 100% coverage
Change example name from Alice to Alicia in all examples
Make new strings translatable
Some fixes:
To validate:
src/screens/Profile/components/ProfileFeedHeader.tsx:353
menú de feeds (menu "of feeds") or menú del feed (menu "of the feed")?
src/view/screens/ProfileList.tsx:683 (and others)
Dejar de fijar?"
TODO: Delete obsolete strings from locales. Is there any criteria to do this, or can they be deleted right away?