Prevent Drawer gesture conflicting with Suggestions scroll #7468
+76
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
fix-sugg-swipe-android - social-app PR #7468
Render
Destroyed
|
haileyok
approved these changes
Jan 17, 2025
estrattonbailey
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Extract BlockDrawerGeesture * Block drawer when scrolling interstitials (cherry picked from commit 9e3f2f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure this gesture doesn't conflict with the drawer:
conflict.mov
Previously the behavior was not consistent (particularly on Android) and scrolling left could make the drawer appear out of the blue. Not anymore.
Implementation-wise, this reuses the approach from #7424. It's not perfect (ideally the drawer would take precedence on a swipe left when the scroll view is resting at x = 0) but we're not going to bother with that.
Test Plan
See video above. This was previously sometimes getting stuck on Android. Particularly on device.
Try Android (verified works on device), iOS (I only tried sim but will test on TF).
No changes on web.