Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basque language ('eu') #7479

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Add Basque language ('eu') #7479

merged 4 commits into from
Jan 24, 2025

Conversation

REALSOULMAN
Copy link
Contributor

PR to add Basque language localization to Bluesky (code: eu)

@surfdude29
Copy link
Contributor

It's always great to see another localization for Bluesky! 🌐🦋

Could I ask you to make two small changes to this PR to fully enable the Basque localization:

Also, the devs ask that localization PRs are reviewed by at least one other native speaker. Is there someone you could ask to do that? :)

@REALSOULMAN
Copy link
Contributor Author

It's always great to see another localization for Bluesky! 🌐🦋

Could I ask you to make two small changes to this PR to fully enable the Basque localization:

Also, the devs ask that localization PRs are reviewed by at least one other native speaker. Is there someone you could ask to do that? :)

Thank you so much for your help, this is my first time. I've made the changes you say and I'll talk with a basque collegue to review, but, excuse me for my ignorance, how can he review it or what does he need to do for review it?

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google translate seems good with these, so I'll merge! Tysm!

@pfrazee pfrazee merged commit 24afc9c into bluesky-social:main Jan 24, 2025
@REALSOULMAN
Copy link
Contributor Author

Google translate seems good with these, so I'll merge! Tysm!

Hahahaha, that's great! Hope the basque users will report mistakes, if any.

Eskerrik asko ("thank you" in basque)

@surfdude29
Copy link
Contributor

Hope the basque users will report mistakes, if any.

If any Basque users would like to try out the new localization they can give it a spin on the dev server at: main.bsky.dev

This is what the @bsky.app profile looks like for instance:

IMG_0422

If you see anything that you'd like to change before the 1.97 release is cut and you submit a new PR in the next 24 hours or so then it should make it into the release, as described here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants